[PATCH 3/9 V2] staging: rtl8192e: Fix smatch info output for r8192E_dev.c

Larry Finger Larry.Finger at lwfinger.net
Thu Sep 1 17:23:15 UTC 2011


Smatch reports the following informational output:

  CHECK   drivers/staging/rtl8192e/r8192E_dev.c
drivers/staging/rtl8192e/r8192E_dev.c +2404 ActUpdateChannelAccessSetting(13) info: ignoring unreachable code.
drivers/staging/rtl8192e/r8192E_dev.c +2404 ActUpdateChannelAccessSetting(13) info: ignoring unreachable code.

Signed-off-by: Larry Finger <Larry.Finger at lwfinger.net>
---

V2 - no changes
---
 drivers/staging/rtl8192e/r8192E_dev.c |   24 +++---------------------
 1 files changed, 3 insertions(+), 21 deletions(-)

diff --git a/drivers/staging/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/r8192E_dev.c
index 899e4e5..808aab6 100644
--- a/drivers/staging/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/r8192E_dev.c
@@ -2387,27 +2387,9 @@ u8 rtl8192_QueryIsShort(u8 TxHT, u8 TxRate, struct cb_desc *tcb_desc)
 	return tmp_Short;
 }
 
-void
-ActUpdateChannelAccessSetting(
-	struct net_device *dev,
+void ActUpdateChannelAccessSetting(struct net_device *dev,
 	enum wireless_mode WirelessMode,
-	struct channel_access_setting *ChnlAccessSetting
-	)
+	struct channel_access_setting *ChnlAccessSetting)
 {
-		struct r8192_priv *priv = rtllib_priv(dev);
-
-		return;
-
-		{
-			u16	SIFS_Timer;
-
-			if (WirelessMode == WIRELESS_MODE_G)
-				SIFS_Timer = 0x0e0e;
-			else
-				 SIFS_Timer = priv->SifsTime;
-
-			priv->rtllib->SetHwRegHandler(dev, HW_VAR_SIFS,
-						     (u8 *)&SIFS_Timer);
-		}
-
+	return;
 }
-- 
1.7.3.4




More information about the devel mailing list