[PATCH 2/2] Staging: bcm: hostmibs: Fixed indentation and other minor style issues.

Joe Perches joe at perches.com
Sun Oct 30 19:58:58 UTC 2011


On Sun, 2011-10-30 at 16:45 -0300, Diego F. Marfil wrote:
> diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c

trivia...

>  VOID CopyMIBSExtendedSFParameters(PMINI_ADAPTER Adapter,
> -		CServiceFlowParamSI *psfLocalSet, UINT uiSearchRuleIndex)
> +				  CServiceFlowParamSI *psfLocalSet,
> +				  UINT uiSearchRuleIndex)
>  {
> -	Adapter->PackInfo[uiSearchRuleIndex].stMibsExtServiceFlowTable.wmanIfSfid = psfLocalSet->u32SFID;
[...]
> +	Adapter->PackInfo[uiSearchRuleIndex].stMibsExtServiceFlowTable.
> +	    wmanIfSfid = psfLocalSet->u32SFID;

Because of the silly name lengths and to avoid excessive
dereferences, it's better to use a temporary.

	typeof(Adapter->PackInfo[uiSearchRuleIndex].stMibsExtServiceFlowTable) *t = 
		&Adapter->PackInfo[uiSearchRuleIndex].stMibsExtServiceFlowTable;

	t->wmanIfSfid = psfLocalSet->u32SFID;

	etc...





More information about the devel mailing list