[PATCH 0/14] staging/media/as102: new driver submission (was Re: [PATCH 1/7] Staging submission: PCTV 74e driver (as102)
Piotr Chmura
chmooreck at poczta.onet.pl
Tue Oct 18 17:20:19 UTC 2011
On Tue, 18 Oct 2011 11:52:17 -0400
Devin Heitmueller <dheitmueller at kernellabs.com> wrote:
> On Tue, Oct 18, 2011 at 5:10 AM, Piotr Chmura <chmooreck at poczta.onet.pl> wrote:
> > Thanks for comments for all of you.
> >
> > [PATCH 1-12/14] Following your guidelines i exported all changes from hg one by one. This way we will have all history in kernel tree.
> > I moved driver to staging/media and removed Kconfig/Makefile changes in parent directory in first patch.
>
> Hello Piotr,
>
> Not that I want to create more work for you, but it would appear that
> your patches stripped off all the Signed-off-by lines for both myself
> and Pierrick Hascoet (the developer from the hardware vendor). You
> have replaced them with "cc:" lines, which breaks the chain of
> "Developer's Certificate of Origin".
>
> When you take somebody else's patches, you need to preserve any
> existing Signed-off-by lines, adding your own at the bottom of the
> list.
>
> In other words, the first patch should be:
>
> Signed-off-by: Pierrick Hascoet <pierrick.hascoet at abilis.com>
> Signed-off-by: Devin Heitmueller <dheitmueller at kernellabs.com>
> Signed-off-by: Piotr Chmura <chmooreck at poczta.onet.pl>
>
> instead of:
>
> Signed-off-by: Piotr Chmura <chmooreck at poczta.onet.pl>
> Cc: Pierrick Hascoet <pierrick.hascoet at abilis.com>
> Cc: Devin Heitmueller <dheitmueller at kernellabs.com>
>
> Devin
>
> --
> Devin J. Heitmueller - Kernel Labs
> http://www.kernellabs.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Ok, i'll resend them again.
Should I replay to every patch with something like [RESEND PATCH nn/mm]..., right ?
Peter
More information about the devel
mailing list