[PATCH 4/4] Staging: bcm: Fix assignment vs. condition bug reported by checkpatch.pl.

Dan Carpenter dan.carpenter at oracle.com
Fri Oct 7 20:30:51 UTC 2011


On Fri, Oct 07, 2011 at 09:29:23AM -0400, Kevin McKinney wrote:
> Thanks for the feedback.  I will fix and resubmit ASAP.  I assume
> BcmFileDownload returns a true when successful, so perhaps it should
> be "if (!status)" ?  Either way, I will confirm, fix, and resubmit.
> 

BcmFileDownload() returns 0 on success and negative error codes on
failure.  It's best not to assume things, I guess...

regards,
dan carpenter



More information about the devel mailing list