[PATCH v2] Staging: iio/accel: Fix calls to obsolete function
Dan Carpenter
dan.carpenter at oracle.com
Thu Nov 24 20:56:57 UTC 2011
On Thu, Nov 24, 2011 at 09:11:14PM +0100, Andreas Ruprecht wrote:
> The checkpatch.pl script marks the function "strict_strtol"
> as obsolete and suggests replacing it with "kstrtol".
>
Some of these change the behavior, so those should be broken out and
justified more clearly. Every behavior change you need to say what
changed, and why.
I can't describe how annoyed I get when I'm going through old patches
and I see something like bc9025bdc "blah blah blah cleanups
simplifications. ps I also fixed a locking bug." The bug fix is
the important bit, and the cleanups can be mentioned in the ps.
regards,
dan carpenter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20111124/9cdd26e7/attachment.asc>
More information about the devel
mailing list