[PATCH 1/4] staging: line6: add Pod HD300 support
Stefan Hajnoczi
stefanha at gmail.com
Thu Nov 24 12:48:56 UTC 2011
On Thu, Nov 24, 2011 at 11:17 AM, Dan Carpenter
<dan.carpenter at oracle.com> wrote:
> On Wed, Nov 23, 2011 at 08:20:42AM +0000, Stefan Hajnoczi wrote:
>> + line6 = &podhd->line6;
>> + if (line6 == NULL)
>> + return;
>
> The address of a pointer is rarely NULL. In this case, although
> ->line6 is the first member of the struct, we've already verified
> that podhd is not NULL so line6 can't be NULL. (Obviously don't
> resend, I'm just pointing it out. Plus it's always nice to know that
> people are reading your patches.).
Thanks for the review. That NULL check was silly :).
Stefan
More information about the devel
mailing list