[PATCH] Split rtl8192e

Dan Carpenter dan.carpenter at oracle.com
Mon Nov 21 06:10:59 UTC 2011


On Sun, Nov 20, 2011 at 08:52:48PM -0800, Sean MacLennan wrote:
> The rtl8192e driver had a natural split between the more generic
> rtllib code and the more specific rtl8192e code. This patch splits the
> driver into two parts and six drivers: rtllib, rtllib_crypt,
> rtllib_crypt_ccmp, rtllib_crypt_tkip, rtllib_crypt_wep and r8192e.
> 
> Most of the code changes where either infrastructure (get it building),
> or the exporting of symbols from rtllib to the r8192e driver.
> 
> Signed-off-by: Sean MacLennan <seanm at seanm.ca>

There are *STILL* unneeded code changes in here...

Seriously, everyone else manages to separate changes out into
different patches.  It's not hard to do.

I hate to make people redo patches over and over again so normally if
I miss something small the first time then I don't point it out on
the second review round.  But in this case, I'm just saying the same
thing over and over and I don't understand, am I not being clear?

regards,
dan carpenter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20111121/d824662f/attachment.asc>


More information about the devel mailing list