[PATCH 2/2] Staging: bcm: Adapter.h Checkpatch cleaning.

Dan Carpenter dan.carpenter at oracle.com
Sat Nov 19 07:19:15 UTC 2011


On Sat, Nov 19, 2011 at 02:19:54AM +0000, Ken O'Brien wrote:
> Removed all checkpatch errors.
> 
> Checkpatch status before: total: 131 errors, 200 warnings, 648 lines checked
> Checkpatch status after:  total: 0 errors, 194 warnings, 620 lines checked
> 

I don't have strong opinions personally, but I think the prefered way
is to do this for one class of errors at a time.  It makes the patch
smaller and easier to review.  Then send the series of patches.

> +typedef union _U_IP_ADDRESS {
> +  struct {
> +		ULONG				ulIpv4Addr[MAX_IP_RANGE_LENGTH];/*Source Ip Address Range */
     ^    ^                  ^                                                  ^ ^
     tab tab            one space only here                                 spaces after the ';' and '*'.
The whitespace on the line above isn't right.

> +      /*
> +      * bit 1: 1 Idlemode enable;
> +      * bit 2: 1 Sleepmode Enable
> +      */

The asterisks should all line up here.

regards,
dan carpenter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20111119/2b400c36/attachment.asc>


More information about the devel mailing list