[PATCH 2/2] Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw()
Lars-Peter Clausen
lars at metafoo.de
Tue Nov 15 15:58:14 UTC 2011
From: Dan Carpenter <dan.carpenter at oracle.com>
ad5360_get_channel_vref() returns an int and scale_uv should be the
same. Making it unsigned here breaks the error handling.
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
Acked-by: Jonathan Cameron <jic23 at cam.ac.uk>
Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
---
drivers/staging/iio/dac/ad5360.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/iio/dac/ad5360.c b/drivers/staging/iio/dac/ad5360.c
index c5bf582..012d714 100644
--- a/drivers/staging/iio/dac/ad5360.c
+++ b/drivers/staging/iio/dac/ad5360.c
@@ -371,8 +371,8 @@ static int ad5360_read_raw(struct iio_dev *indio_dev,
long m)
{
struct ad5360_state *st = iio_priv(indio_dev);
- unsigned long scale_uv;
unsigned int ofs_index;
+ int scale_uv;
int ret;
switch (m) {
--
1.7.7.1
More information about the devel
mailing list