[PATCH] gma500: Use kmemdup rather than duplicating its implementation

Thomas Meyer thomas at m3y3r.de
Sat Nov 12 17:02:45 UTC 2011


Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas at m3y3r.de>
---

diff -u -p a/drivers/staging/gma500/intel_bios.c b/drivers/staging/gma500/intel_bios.c
--- a/drivers/staging/gma500/intel_bios.c 2011-11-07 19:38:10.703630794 +0100
+++ b/drivers/staging/gma500/intel_bios.c 2011-11-08 10:52:10.090491565 +0100
@@ -104,12 +104,11 @@ static void parse_backlight_data(struct
 	bl_start = find_section(bdb, BDB_LVDS_BACKLIGHT);
 	vbt_lvds_bl = (struct bdb_lvds_backlight *)(bl_start + 1) + p_type;
 
-	lvds_bl = kzalloc(sizeof(*vbt_lvds_bl), GFP_KERNEL);
+	lvds_bl = kmemdup(vbt_lvds_bl, sizeof(*vbt_lvds_bl), GFP_KERNEL);
 	if (!lvds_bl) {
 		dev_err(dev_priv->dev->dev, "out of memory for backlight data\n");
 		return;
 	}
-	memcpy(lvds_bl, vbt_lvds_bl, sizeof(*vbt_lvds_bl));
 	dev_priv->lvds_bl = lvds_bl;
 }
 






More information about the devel mailing list