[PATCH] drivers/staging/vt6656/iwctl.c: Remove PRINT_K macro

Marcos Souza marcos.mage at gmail.com
Mon Nov 7 11:52:55 UTC 2011


2011/11/7, Dan Carpenter <dan.carpenter at oracle.com>:
> On Mon, Nov 07, 2011 at 07:27:52AM -0300, Marcos Souza wrote:
>> 2011/11/7, Dan Carpenter <dan.carpenter at oracle.com>:
>> > Hi Marcos,
>> >
>> > This should be sent to devel at driverdev.osuosl.org as well.
>> On copy this time
>> > DBG_PRT() is just as bad as PRINT_K().  The first example in
>> > iwctl_siwscan() should be either pr_debug() or dev_dbg().  Also the
>> > message itself is wrong.
>> So, I'll send patches to change all these print_k and dbg_prt to dev_dbg
>
> It's not as simple as doing a sed over the driver.  You have to look
> at each one and decide what it should be.  I only looked at the first
> PRINT_K() and said specific one should be a pr_debug() not that all
> of them should.
Sorry, I think I was not so clear as I wanted. I'll analyse all the
uses of dbg_prt and print_k, and change these as they can be assigned
to pr_debug and dev_dbg.
> regards,
> dan carpenter
>
>


-- 
Marcos Paulo de Souza

*Porque uma vida sem desafios é uma vida sem razão.*



More information about the devel mailing list