[PATCH] Staging: bcm: Fix information leak in ioctl, IOCTL_BCM_REGISTER_READ_PRIVATE

Kevin McKinney klmckinney1 at gmail.com
Sat Nov 5 19:43:11 UTC 2011


Hi Dan,
On Sat, Nov 5, 2011 at 2:44 PM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> This looks like another info leak the same as the one in
> IOCTL_BCM_REGISTER_READ_PRIVATE.  Could you change
> "IoBuffer.OutputLength" to "bytes" here?
>
>>                               Status = -EFAULT;
>> +             } else {
>> +                     Status = bytes;
>> +             }

Sure, I noticed this also, but thought we would fix in another patch.

> When you've made that change can you resend with a:
> Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>

Will do.

Thanks,
Kevin



More information about the devel mailing list