Plan for ath6kl cleanup

Greg KH gregkh at suse.de
Sat May 21 03:11:35 UTC 2011


On Fri, May 20, 2011 at 09:51:21AM -0700, Joe Perches wrote:
> On Fri, 2011-05-20 at 10:29 -0400, Christoph Hellwig wrote:
> > On Fri, May 20, 2011 at 06:36:00AM -0700, Greg KH wrote:
> > > On Fri, May 20, 2011 at 04:13:24PM +0300, Kalle Valo wrote:
> > > > We have been thinking about how to get ath6kl out from staging and get
> > > > it to a first class citizen under drivers/net/wireless. There's quite a
> > > > lot of work to do get ath6kl cleaned up and the prospect of doing all
> > > > that through the staging-next tree wasn't that exciting. We would be
> > > > sending hundreds of patches and it would take a long time to cleanup the
> > > > driver. And the disconnection from the wireless core development also
> > > > sounded very daunting (cfg80211 API changes etc.).
> > > 
> > > This sounds like, "We don't like the kernel development model, it
> > > requires us to break everything up into small patches and show our work
> > > to everyone."
> > 
> > It's not the kernel development mode, it's something that you try to
> > impose on staging users.  Creating a more less new driver from a pig
> > pile of junk doesn't make sense minimized patches with micro-review.
> 
> I tried it once on ath6kl.
> Ended up with ~300 patches and a very clean tree.

Yes it can be done, and others do it for other drivers, it just takes a
bit of effort.

But as this is pretty much a total rewrite, that's fine to do
out-of-tree and then just submit it for inclusion in the main wireless
tree and then we can delete this driver.

We've done this for other wireless drivers, so it wouldn't be the first
time.  I just wanted to make sure that it wasn't something with how the
overall development process was working that caused this.

thanks,

greg k-h



More information about the devel mailing list