[PATCH 14/64] Staging: hv: Include asm/hyperv.h in hyperv.h

Greg KH gregkh at suse.de
Tue May 17 19:09:43 UTC 2011


On Tue, May 17, 2011 at 07:02:01PM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:greg at kroah.com]
> > Sent: Tuesday, May 17, 2011 2:46 PM
> > To: KY Srinivasan
> > Cc: gregkh at suse.de; devel at linuxdriverproject.org; Haiyang Zhang; Abhishek
> > Kane (Mindtree Consulting PVT LTD); Hank Janssen
> > Subject: Re: [PATCH 14/64] Staging: hv: Include asm/hyperv.h in hyperv.h
> > 
> > On Thu, May 12, 2011 at 07:34:27PM -0700, K. Y. Srinivasan wrote:
> > > Include asm/hyperv.h in hyperv.h.
> > 
> > Huh?  There is no "asm/hyperv.h" file.
> 
> Why do you say there is no asm/hyperv.h; look under
> arch/x86/include/asm. This file was introduced a while ago and already had
> many definitions that we had in  one of our local files (hv_api.h).
> So in the spirit of getting rid of duplicate definitions, I included an existing file
> (asm/hyperv.h).  So, I had get rid of duplicate definitions in our local file.

Ah, I had not noticed that at all, my fault.

You could have said "delete the duplicate entries already covered by..."
which would have made a bit more sense for dense people like myself :)

I'll go dig these up and edit this file and see how the rest shake
out.

thanks,

greg k-h



More information about the devel mailing list