[PATCH 04/32] staging: brcm80211: got rid of #ifdef __mips__ sections in hnddma.c

Jonas Gorski jonas.gorski at gmail.com
Sat May 14 10:16:31 UTC 2011


On 13 May 2011 11:59, Arend van Spriel <arend at broadcom.com> wrote:
> From: Roland Vossen <rvossen at broadcom.com>
>
> Code cleanup. Broadcom MIPS chips in big endian mode have a memory window
> in which sdram contents is byte swapped. Code in hnddmac.c makes use of
> this window. Reworked code so the #ifdef __mips__ is moved from .c to
> .h file.

Shouldn't this be guarded with e.g. CONFIG_BCM63XX instead of
__mips__? Not every big endian mips is a broadcom ;-). I don't know if
there are further Broadcom ones, the only other I know is bcm47xx and
that one is little endian.

Regards
Jonas



More information about the devel mailing list