[PATCH 152/206] Staging: hv: Create a common header for all hyperv drivers to include

KY Srinivasan kys at microsoft.com
Wed May 11 22:34:41 UTC 2011



> -----Original Message-----
> From: Greg KH [mailto:greg at kroah.com]
> Sent: Wednesday, May 11, 2011 4:55 PM
> To: KY Srinivasan
> Cc: gregkh at suse.de; devel at linuxdriverproject.org; Haiyang Zhang; Abhishek
> Kane (Mindtree Consulting PVT LTD)
> Subject: Re: [PATCH 152/206] Staging: hv: Create a common header for all hyperv
> drivers to include
> 
> On Tue, May 10, 2011 at 07:56:18AM -0700, K. Y. Srinivasan wrote:
> > Create a common header (hyperv.h)  for all hyperv drivers to include.
> > Free at last ...
> 
> Nope, not so quick, you're still chained down :)
> 
> Here's where I stopped in applying patches, I did the first 151, which
> was a good run...
> 
> A few notes on when you redo the remaining patches.
> 
> When you create the hyperv.h file, move the stuff from one .h file into
> this one at the same time, don't do a "add the structures" in one patch,
> and then "delete the structures from the old one" on another.  By doing
> it in one patch, git can better track things when they move to keep the
> history sane when trying to research things in the past.

Just to be sure, you want the add/delete to happen in one patch. You still
want the addition/deletion of each header file to be in a separate patch; right?

Regards,

K. Y 



More information about the devel mailing list