[PATCH 031/206] Staging: hv: storvsc: Get rid of some unnecessary DPRINTS

KY Srinivasan kys at microsoft.com
Wed May 11 16:49:25 UTC 2011



> -----Original Message-----
> From: Greg KH [mailto:greg at kroah.com]
> Sent: Wednesday, May 11, 2011 12:34 PM
> To: KY Srinivasan
> Cc: gregkh at suse.de; devel at linuxdriverproject.org; Haiyang Zhang; Abhishek
> Kane (Mindtree Consulting PVT LTD)
> Subject: Re: [PATCH 031/206] Staging: hv: storvsc: Get rid of some unnecessary
> DPRINTS
> 
> On Tue, May 10, 2011 at 07:54:17AM -0700, K. Y. Srinivasan wrote:
> > The subject line says it all.
> >
> > Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
> > Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com>
> > Signed-off-by: Abhishek Kane <v-abkane at microsoft.com>
> > Signed-off-by: Hank Janssen <hjanssen at microsoft.com>
> > ---
> >  drivers/staging/hv/storvsc.c |  116 ++++++------------------------------------
> >  1 files changed, 16 insertions(+), 100 deletions(-)
> >
> > diff --git a/drivers/staging/hv/storvsc.c b/drivers/staging/hv/storvsc.c
> > index 5d5aec3..41361f5 100644
> > --- a/drivers/staging/hv/storvsc.c
> > +++ b/drivers/staging/hv/storvsc.c
> > @@ -113,11 +113,8 @@ static int storvsc_channel_init(struct hv_device
> *device)
> >  	int ret, t;
> >
> >  	stor_device = get_stor_device(device);
> > -	if (!stor_device) {
> > -		DPRINT_ERR(STORVSC, "unable to get stor device..."
> > -			   "device being destroyed?");
> > +	if (!stor_device)
> >  		return -1;
> 
> Just a note for future things to clean up.  Never return -1, please use
> proper -ERR* values instead.

Will do.

Regards,

K. Y




More information about the devel mailing list