[PATCH 000/206] Staging: hv: Cleanup hv drivers

Greg KH greg at kroah.com
Wed May 11 16:16:55 UTC 2011


On Wed, May 11, 2011 at 03:06:14PM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:greg at kroah.com]
> > Sent: Wednesday, May 11, 2011 10:49 AM
> > To: KY Srinivasan
> > Cc: gregkh at suse.de; devel at linuxdriverproject.org
> > Subject: Re: [PATCH 000/206] Staging: hv: Cleanup hv drivers
> > 
> > On Tue, May 10, 2011 at 07:56:34AM -0700, K. Y. Srinivasan wrote:
> > > This is a resend of the patches sent on May 9, 2011. Per Greg's
> > > suggestion, I have include additional context to the Subject line
> > > where there was some ambiguity.
> > >
> > > This patch-set deals with some of the architectural isues in all of
> > > the Hyper-V drivers. Specifically:
> > 
> > They finally all came through now, or at least I think they all did.
> > 
> > Please fix your email system to not swallow them for 8+ hours in the
> > future, this really isn't an acceptable way of doing work.
> > 
> > > 	1) Fixes a number of locking issues in the block driver.
> > >
> > > 	2) Eliminates all the indirection through the hv_driver
> > > 	   abstraction.
> > >
> > > 	3) Simplifies the code across the board eliminating
> > > 	   unnecessary code and data structure layering. Prior to
> > > 	   this restructuring there were about 11,000 lines of code
> > > 	   in the hv directory. After this cleanup, there are about
> > > 	   8500 lines of code.
> > 
> > That's great, remember how many lines were at the beginning?  I think it
> > was over 40000 or so, but I could be wrong, I should go and dig up the
> > original code dump from so long ago to be sure...
> > 
> > > 	4) I have dealt with style and naming issues across all the drivers.
> > >
> > > 	5) All the header files have been cleaned up and consolidated:
> > > 		1) A single header file include/linux/hyperv.h. This file
> > > 		   is to be included in all the drivers that attach to the
> > > 		   vmbus.
> > 
> > Woah, no.  You can't move out of the drivers/staging/hv/ directory yet,
> > sorry.  I'll go through and review and try to apply these patches but
> > will probably stop when you do this file movement, sorry.  I'll let you
> > know how far I get when I do this.
> 
> My mistake Greg; I was under the impression that this is what you wanted.
> Do you want me to move this file back to the hv directory; I will have to re-spin 
> all the patches after that. Let me know if I should go ahead and do that. 

No, let me start going through what you have sent already, I don't want
your poor email server to crash again by you having to resend them so
quickly :)

thanks,

greg k-h



More information about the devel mailing list