[PATCH v6] staging: Add ST-Ericsson CG2900 driver

Greg KH greg at kroah.com
Wed May 11 01:56:50 UTC 2011


On Wed, May 11, 2011 at 02:07:33AM +0200, Linus Walleij wrote:
> 2011/5/10 Greg KH <greg at kroah.com>:
> 
> > On Tue, May 10, 2011 at 05:10:32PM +0200, Par-Gunnar Hjalmdahl wrote:
> >> This patch adds support for the ST-Ericsson CG2900
> >> Connectivity Combo controller (Bluetooth, FM, GPS).
> >>
> >> Signed-off-by: Par-Gunnar Hjalmdahl <par-gunnar.p.hjalmdahl at stericsson.com>
> >> Acked-by: Linus Walleij <linus.walleij at linaro.org>
> >
> > {sigh}
> >
> > This breaks the build again, the error messages are below :(
> 
> I suspect the problem is that Per-Gunnar does not know how to reproduce
> your build errors. Are you building for some x86 combination, allyes, etc
> for example? This is likely currently only tested and applicable for ux500
> so a simple  "depends on ARCH_U8500" under config CG2900 may solve
> stuff.

All I did was merely enable the driver to be built on my desktop,
something that any developer should have done, right?

And why can't the code be built for any architecture, what is forcing it
for only one platform?  That's not the way drivers should be written,
right?

So please fix the real problem, don't just confine it to one
architecture, what is to keep this from showing up on another chip soon?

thanks,

greg k-h



More information about the devel mailing list