[PATCH 1/2] Staging: brcm80211: coding issues treatment

Guilherme Salazar salazartux at gmail.com
Mon May 9 23:54:08 UTC 2011


This patch fixes up some brace coding and spaces at the
start of a line issues. In this source file, there are
lots of warnings related to line over 80 characters, but
this patch doesn't fixes it up.

Signed-off-by: Guilherme Salazar <salazartux at gmail.com>
---
 drivers/staging/brcm80211/brcmsmac/wlc_ampdu.c |   33 +++++++++++-------------
 1 files changed, 15 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/brcm80211/brcmsmac/wlc_ampdu.c b/drivers/staging/brcm80211/brcmsmac/wlc_ampdu.c
index f008659..57940b7 100644
--- a/drivers/staging/brcm80211/brcmsmac/wlc_ampdu.c
+++ b/drivers/staging/brcm80211/brcmsmac/wlc_ampdu.c
@@ -78,12 +78,12 @@

 #ifdef BCMDBG
 u32 wl_ampdu_dbg =
-    WL_AMPDU_UPDN_VAL |
-    WL_AMPDU_ERR_VAL |
-    WL_AMPDU_TX_VAL |
-    WL_AMPDU_RX_VAL |
-    WL_AMPDU_CTL_VAL |
-    WL_AMPDU_HW_VAL | WL_AMPDU_HWTXS_VAL | WL_AMPDU_HWDBG_VAL;
+	WL_AMPDU_UPDN_VAL |
+	WL_AMPDU_ERR_VAL |
+	WL_AMPDU_TX_VAL |
+	WL_AMPDU_RX_VAL |
+	WL_AMPDU_CTL_VAL |
+	WL_AMPDU_HW_VAL | WL_AMPDU_HWTXS_VAL | WL_AMPDU_HWDBG_VAL;
 #endif

 /* structure to hold tx fifo information and pre-loading state
@@ -229,9 +229,8 @@ void wlc_ampdu_detach(struct ampdu_info *ampdu)
 		return;
 
 	/* free all ini's which were to be freed on callbacks which were never called */
-	for (i = 0; i < AMPDU_INI_FREE; i++) {
+	for (i = 0; i < AMPDU_INI_FREE; i++)
 		kfree(ampdu->ini_free[i]);
-	}
 
 	wlc_module_unregister(ampdu->wlc->pub, "ampdu", ampdu);
 	kfree(ampdu);
@@ -245,9 +244,9 @@ void scb_ampdu_cleanup(struct ampdu_info *ampdu, struct scb *scb)
 	WL_AMPDU_UPDN("scb_ampdu_cleanup: enter\n");
 	ASSERT(scb_ampdu);
 
-	for (tid = 0; tid < AMPDU_MAX_SCB_TID; tid++) {
+	for (tid = 0; tid < AMPDU_MAX_SCB_TID; tid++)
 		ampdu_cleanup_tid_ini(ampdu, scb_ampdu, tid, false);
-	}
+
 }
 
 /* reset the ampdu state machine so that it can gracefully handle packets that were
@@ -375,9 +374,9 @@ static int wlc_ffpld_check_txfunfl(struct wlc_info *wlc, int fid)
 	txunfl_ratio = current_ampdu_cnt / fifo->accum_txfunfl;
 
 	if (txunfl_ratio > ampdu->tx_max_funl) {
-		if (current_ampdu_cnt >= FFPLD_MAX_AMPDU_CNT) {
+		if (current_ampdu_cnt >= FFPLD_MAX_AMPDU_CNT)
 			fifo->accum_txfunfl = 0;
-		}
+
 		return 0;
 	}
 	max_mpdu =
@@ -481,9 +480,9 @@ wlc_ampdu_agg(struct ampdu_info *ampdu, struct scb *scb, struct sk_buff *p,
 
 	/* initialize initiator on first packet; sends addba req */
 	ini = SCB_AMPDU_INI(scb_ampdu, tid);
-	if (ini->magic != INI_MAGIC) {
+	if (ini->magic != INI_MAGIC)
 		ini = wlc_ampdu_init_tid_ini(ampdu, scb_ampdu, tid, false);
-	}
+
 	return;
 }
 
@@ -541,9 +540,8 @@ wlc_sendampdu(struct ampdu_info *ampdu, struct wlc_txq_info *qi,
 
 	/* Let pressure continue to build ... */
 	qlen = pktq_plen(&qi->q, prec);
-	if (ini->tx_in_transit > 0 && qlen < scb_ampdu->max_pdu) {
+	if (ini->tx_in_transit > 0 && qlen < scb_ampdu->max_pdu)
 		return BCME_BUSY;
-	}
 
 	wlc_ampdu_agg(ampdu, scb, p, tid);
 
@@ -1018,9 +1016,8 @@ wlc_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
 	supr_status = txs->status & TX_STATUS_SUPR_MASK;
 
 	if (txs->status & TX_STATUS_ACK_RCV) {
-		if (TX_STATUS_SUPR_UF == supr_status) {
+		if (TX_STATUS_SUPR_UF == supr_status)
 			update_rate = false;
-		}
 
 		ASSERT(txs->status & TX_STATUS_INTERMEDIATE);
 		start_seq = txs->sequence >> SEQNUM_SHIFT;
-- 
1.7.2.5




More information about the devel mailing list