[PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver

Russell King - ARM Linux linux at arm.linux.org.uk
Sun May 8 10:16:09 UTC 2011

On Sat, May 07, 2011 at 08:48:10PM +0200, Rafał Miłecki wrote:
> Really, what's wrong with that? Does it kill anyone's pet we print
> this? We also do:
> pr_err("Scanning failed because of wrong CID\n");
> return -1;
> While we could drop pr_err. Why to do this? Advanced used can always
> check what -1 means.

And why return -1 when we have a system of error codes?  I _really_ wish
people would stop returning -1 for "some random error occurred".

More information about the devel mailing list