[PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver

George Kashperko george at znau.edu.ua
Sat May 7 19:35:56 UTC 2011


> I'll ask linux-wireless instead of linux-usb or linux-arm.
If you know you haven't got wireless working by some reason you will ask
at linux-wireless anyway. And people there will ask you for id/ven/rev
rather than core name reported by bus driver.

> I didn't expect longer discussion so I got this trivial example of
> pr_err. But it appears to be good example/question.
> 
> How do you see relation between bcma_device_name and:
> int zd_ioread32v_locked(...) {
> 	if (r) {
> 		dev_dbg_f(zd_chip_dev(chip),
> 			  "error: zd_ioread16v_locked. Error number %d\n", r);
> 		return r;
> 	}
> }
No relation at all. It like comparing warm and soft. It will be if you
do something like

dbg_bcma_device_name
{
#ifdef DEBUG
		case/switch/if/else stuff
#endif
		return NULL;
}
But I don't see here much sense to hardcode names other than those of
buscommons/buscores for debugging purposes.

> 
> I believe according to your theory we should drop thi error message,
> right? It eats memory to keep this string while error code can always
> be checked in source.
> 
My theory ? o.O

Have nice day,
George





More information about the devel mailing list