[PATCH 2/2] staging: brcm80211: replace asserts close to Mac80211 interface

Greg KH gregkh at suse.de
Tue Mar 29 13:16:21 UTC 2011


On Tue, Mar 29, 2011 at 02:03:36PM +0200, Roland Vossen wrote:
> The reason that I am investing time in the ASSERT/WARN_ON etc
> patches is that Greg KH does not want ASSERT statement in our
> driver. It would be great if I could simply replace all ASSERTs with
> WARN_ONs (inversing the condition checked of course), so I can focus
> on improving code readability.

That doesn't make sense, why replace them all with warnings?  Why would
those thing ever need an assert in the first place?  Please rework the
code to never need them, or, if they are a real case, then properly
handle them without a warning being sent to the user who really has no
idea how to handle them.

thanks,

greg k-h



More information about the devel mailing list