[PATCH 5/6] Staging: rts_pstor: redundant null check before kfree()

Alexander Beregalov a.beregalov at gmail.com
Sat Mar 26 17:18:13 UTC 2011


Signed-off-by: Alexander Beregalov <a.beregalov at gmail.com>
---
 drivers/staging/rts_pstor/ms.c |   12 +++---------
 1 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c
index 5ac217b..5ca7c76 100644
--- a/drivers/staging/rts_pstor/ms.c
+++ b/drivers/staging/rts_pstor/ms.c
@@ -3816,9 +3816,7 @@ int mg_get_local_EKB(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 	rtsx_stor_set_xfer_buf(buf, bufflen, srb);
 
 GetEKBFinish:
-	if (buf) {
-		kfree(buf);
-	}
+	kfree(buf);
 	return retval;
 }
 
@@ -4054,9 +4052,7 @@ int mg_get_ICV(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 	rtsx_stor_set_xfer_buf(buf, bufflen, srb);
 
 GetICVFinish:
-	if (buf) {
-		kfree(buf);
-	}
+	kfree(buf);
 	return retval;
 }
 
@@ -4155,9 +4151,7 @@ int mg_set_ICV(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 #endif
 
 SetICVFinish:
-	if (buf) {
-		kfree(buf);
-	}
+	kfree(buf);
 	return retval;
 }
 
-- 
1.7.4.1




More information about the devel mailing list