[PATCH] STAGING: brcm80211 keep power on in suspend state

Dan Carpenter error27 at gmail.com
Fri Mar 18 21:44:47 UTC 2011


On Fri, Mar 18, 2011 at 09:22:02AM -0700, Grant Grundler wrote:
> On Fri, Mar 18, 2011 at 12:05 AM, Dan Carpenter <error27 at gmail.com> wrote:
> ...
> >>  static s32 wl_cfg80211_suspend(struct wiphy *wiphy)
> >>  {
> >> +     void sdioh_sdio_set_host_pm_flags(int flag);
> >> +
> >
> > Let's not put the function declaration here...  Better at the top of the
> > file with all the others.
> 
> No problem. I'll resubmit with the declaration at the top (much) later today.
> 
> Funny thing is Venkat sent the patch that way to me...but this feels
> like an intermediate step in the development of this driver and I
> wanted to make the scope of the function as narrow as possible so the
> next steps are not harder.
> 

Declaring it any place outside the function would be fine.

regards,
dan carpenter



More information about the devel mailing list