[PATCH 785/961] USB: ene_ub6250: fix memory leak in ene_load_bincode()
Greg Kroah-Hartman
gregkh at suse.de
Wed Mar 16 21:07:08 UTC 2011
From: Dan Carpenter <error27 at gmail.com>
"buf" gets allocated twice in a row. It's the second allocation which
is correct. The first one should be removed.
Signed-off-by: Dan Carpenter <error27 at gmail.com>
Acked-by: huajun li <huajun.li.lee at gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
drivers/usb/storage/ene_ub6250.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 058c5d5..08e0374 100644
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -491,10 +491,6 @@ static int ene_load_bincode(struct us_data *us, unsigned char flag)
if (info->BIN_FLAG == flag)
return USB_STOR_TRANSPORT_GOOD;
- buf = kmalloc(ENE_BIN_CODE_LEN, GFP_KERNEL);
- if (buf == NULL)
- return USB_STOR_TRANSPORT_ERROR;
-
switch (flag) {
/* For SD */
case SD_INIT1_PATTERN:
--
1.7.4.1
More information about the devel
mailing list