[PATCH 649/961] Staging: hv: mouse_vsc: fix comment coding style

Greg Kroah-Hartman gregkh at suse.de
Wed Mar 16 21:04:52 UTC 2011


Also mark this as a nice FIXME as we shouldn't ever
care about the value of an atomic variable, which makes me seriously
doubt the validity of this reference counting code.  Odds are it can be
ripped out completly, or at the very least, converted to using a kref.

Cc: Hank Janssen <hjanssen at microsoft.com>
Cc: K. Y. Srinivasan <kys at microsoft.com>
Cc: Haiyang Zhang <haiyangz at microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
 drivers/staging/hv/mouse_vsc.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/hv/mouse_vsc.c b/drivers/staging/hv/mouse_vsc.c
index 659f118..b75066d 100644
--- a/drivers/staging/hv/mouse_vsc.c
+++ b/drivers/staging/hv/mouse_vsc.c
@@ -157,8 +157,14 @@ static inline struct mousevsc_dev *GetInputDevice(struct hv_device *Device)
 
 	inputDevice = (struct mousevsc_dev *)Device->ext;
 
-//	printk(KERN_ERR "-------------------------> REFCOUNT = %d",
-//	       inputDevice->RefCount);
+/*
+ *	FIXME
+ *	This sure isn't a valid thing to print for debugging, no matter
+ *	what the intention is...
+ *
+ *	printk(KERN_ERR "-------------------------> REFCOUNT = %d",
+ *	       inputDevice->RefCount);
+ */
 
 	if (inputDevice && atomic_read(&inputDevice->RefCount) > 1)
 		atomic_inc(&inputDevice->RefCount);
-- 
1.7.4.1




More information about the devel mailing list