[PATCH 672/961] Staging: hv: hv_mouse: use an anonymous union for struct mousevsc_prt_msg

Greg Kroah-Hartman gregkh at suse.de
Wed Mar 16 21:05:15 UTC 2011


Much nicer than having an ugly 'u.' in the structure usage, welcome to
the 2000's...

Cc: Hank Janssen <hjanssen at microsoft.com>
Cc: K. Y. Srinivasan <kys at microsoft.com>
Cc: Haiyang Zhang <haiyangz at microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
 drivers/staging/hv/hv_mouse.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
index 816f4b4..b8760da 100644
--- a/drivers/staging/hv/hv_mouse.c
+++ b/drivers/staging/hv/hv_mouse.c
@@ -160,7 +160,7 @@ struct  mousevsc_prt_msg {
 		struct synthhid_protocol_request Request;
 		struct synthhid_protocol_response Response;
 		struct synthhid_device_info_ack Ack;
-	} u;
+	};
 };
 
 /*
@@ -385,9 +385,9 @@ static void MousevscOnReceiveDeviceInfo(struct mousevsc_dev *InputDevice, struct
 	ack.PacketType = PipeMessageData;
 	ack.DataSize = sizeof(struct synthhid_device_info_ack);
 
-	ack.u.Ack.header.type = SynthHidInitialDeviceInfoAck;
-	ack.u.Ack.header.size = 1;
-	ack.u.Ack.reserved = 0;
+	ack.Ack.header.type = SynthHidInitialDeviceInfoAck;
+	ack.Ack.header.size = 1;
+	ack.Ack.reserved = 0;
 
 	ret = vmbus_sendpacket(InputDevice->Device->channel,
 			&ack,
@@ -608,9 +608,9 @@ static int MousevscConnectToVsp(struct hv_device *Device)
 	request->PacketType = PipeMessageData;
 	request->DataSize = sizeof(struct synthhid_protocol_request);
 
-	request->u.Request.header.type = SynthHidProtocolRequest;
-	request->u.Request.header.size = sizeof(unsigned long);
-	request->u.Request.version_requested.version = SYNTHHID_INPUT_VERSION;
+	request->Request.header.type = SynthHidProtocolRequest;
+	request->Request.header.size = sizeof(unsigned long);
+	request->Request.version_requested.version = SYNTHHID_INPUT_VERSION;
 
 	pr_info("synthhid protocol request...");
 
@@ -635,7 +635,7 @@ static int MousevscConnectToVsp(struct hv_device *Device)
 
 	response = &inputDevice->ProtocolResp;
 
-	if (!response->u.Response.approved) {
+	if (!response->Response.approved) {
 		pr_err("synthhid protocol request failed (version %d)",
 		       SYNTHHID_INPUT_VERSION);
 		ret = -1;
-- 
1.7.4.1




More information about the devel mailing list