[PATCH 465/961] staging: zcache: fix memory leak

Greg Kroah-Hartman gregkh at suse.de
Wed Mar 16 21:01:48 UTC 2011


From: Vasiliy Kulikov <segoon at openwall.com>

obj is not freed if __get_free_page() failed.

Signed-off-by: Vasiliy Kulikov <segoon at openwall.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
 drivers/staging/zcache/zcache.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/zcache/zcache.c b/drivers/staging/zcache/zcache.c
index 61be849..b8a2b30 100644
--- a/drivers/staging/zcache/zcache.c
+++ b/drivers/staging/zcache/zcache.c
@@ -790,6 +790,7 @@ static int zcache_do_preload(struct tmem_pool *pool)
 	page = (void *)__get_free_page(ZCACHE_GFP_MASK);
 	if (unlikely(page == NULL)) {
 		zcache_failed_get_free_pages++;
+		kmem_cache_free(zcache_obj_cache, obj);
 		goto unlock_out;
 	}
 	preempt_disable();
-- 
1.7.4.1




More information about the devel mailing list