[PATCH 412/961] staging/easycap: don't mask return value of usb_control_msg() by 0xFF
Greg Kroah-Hartman
gregkh at suse.de
Wed Mar 16 21:00:55 UTC 2011
From: Tomas Winkler <tomas.winkler at intel.com>
masking return value of usb_control_msg() will mask negative
error values into positive.
Cc: Mike Thomas <rmthomas at sciolus.org>
Reported-by: Dan Carpenter <error27 at gmail.com>
Signed-off-by: Tomas Winkler <tomas.winkler at intel.com>
Reviewed-by: Dan Carpenter <error27 at gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
drivers/staging/easycap/easycap_low.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/easycap/easycap_low.c b/drivers/staging/easycap/easycap_low.c
index 7b2de10..5c41a27 100644
--- a/drivers/staging/easycap/easycap_low.c
+++ b/drivers/staging/easycap/easycap_low.c
@@ -270,7 +270,7 @@ static int regget(struct usb_device *pusb_device,
0x00,
index, reg, reg_size, 50000);
- return 0xFF & rc;
+ return rc;
}
static int regset(struct usb_device *pusb_device, u16 index, u16 value)
--
1.7.4.1
More information about the devel
mailing list