[PATCH 347/961] Staging: rts_pstor: fix read past end of buffer
Greg Kroah-Hartman
gregkh at suse.de
Wed Mar 16 20:59:50 UTC 2011
From: Dan Carpenter <error27 at gmail.com>
We read one space past the end of the buffer because we add 1.
Also I changed it to use ARRAY_SIZE() instead of manually calculating
the size.
Signed-off-by: Dan Carpenter <error27 at gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
---
drivers/staging/rts_pstor/ms.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c
index dd59931..a624f40 100644
--- a/drivers/staging/rts_pstor/ms.c
+++ b/drivers/staging/rts_pstor/ms.c
@@ -3361,7 +3361,7 @@ static int ms_rw_multi_sector(struct scsi_cmnd *srb, struct rtsx_chip *chip, u32
log_blk = (u16)(start_sector >> ms_card->block_shift);
start_page = (u8)(start_sector & ms_card->page_off);
- for (seg_no = 0; seg_no < sizeof(ms_start_idx)/2; seg_no++) {
+ for (seg_no = 0; seg_no < ARRAY_SIZE(ms_start_idx) - 1; seg_no++) {
if (log_blk < ms_start_idx[seg_no+1])
break;
}
--
1.7.4.1
More information about the devel
mailing list