[PATCH 2/2] staging: rts_pstor: set lun_mode in a differentplace

wwang wei_wang at realsil.com.cn
Tue Mar 15 08:56:38 UTC 2011


于 2011年03月15日 16:46, Dan Carpenter 写道:
> Hm...  The auto detect code is never run because chip->use_hw_setting is
> always 0.  Are you sure the right fix isn't to set chip->use_hw_setting
> to 1?
>
> regards,
> dan carpenter
>
Yes, setting chip->use_hw_setting is not a wise choice.
Normally, if chip->use_hw_setting is set to 1, more configurations will
be turned on, such as auto_delink_en.
auto_delink_en can only work well when pcie hotplug is configured and
pciehp.pciehp_force is set to 1. This condition can't be met in default
kernel config by now.
So, I have to choose to set lun_mode detection code in a different place.

Best regards,
wwang



More information about the devel mailing list