[PATCH 21/22] staging: xgifb: rename XGINew_SetRegANDOR() to xgifb_reg_and_or()
Dan Carpenter
error27 at gmail.com
Fri Mar 11 21:37:40 UTC 2011
On Thu, Mar 10, 2011 at 11:02:46PM +0200, Aaro Koskinen wrote:
> Rename XGINew_SetRegANDOR() to xgifb_reg_and_or().
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen at iki.fi>
> ---
> -void XGINew_SetRegANDOR(unsigned long Port, unsigned short Index,
> - unsigned short DataAND, unsigned short DataOR)
> +void xgifb_reg_and_or(unsigned long port, u8 index, unsigned data_and,
^^^^^^^^ ^^^^^^^^^^^^^^^^^
> + unsigned data_or)
^^^^^^^^^^^^^^^^
I wish the change log had mentioned some of these data type changes. It
doesn't cause a bug, but it still should have been mentioned.
> {
> - unsigned short temp;
> + u8 temp;
regards,
dan carpenter
More information about the devel
mailing list