[PATCH 2/2] Staging: bcm: Bcmnet: fixed 'checkpatch.pl' issues

Vinay Sawal vinaysawal at gmail.com
Wed Mar 9 19:50:54 UTC 2011


On Wed, Mar 9, 2011 at 9:36 AM, Dan Carpenter <error27 at gmail.com> wrote:
> On Tue, Mar 08, 2011 at 10:58:22PM -0800, Vinay Sawal wrote:
>> Fixed all issues reported by 'checkpatch.pl' for this file.
>>
>> Signed-off-by: Vinay Sawal <vinaysawal at gmail.com>
>> ---
>> +
>> +#define __NO_VERSION__
>
> What do these __NO_VERSION__ defines do?

Based on my limited knowledge of 'drivers/staging/*' files, this macro
__NO_VERSION__ is used to conditionally compile the files for various
versions of the driver. But looking through the diffs again, I think I
shouldn't have added it in there since I don't have the complete
background of the relevant files.

Shall I generate a new patch without the __NO_VERSION__ macro ? Please
let me know.

Thanks,
Vinay


>
>>  #include "headers.h"
>
> regards,
> dan carpenter
>



More information about the devel mailing list