[PATCH 11/21] staging: ft1000: Fix coding style in ft1000_usb_transmit_complete function.
Greg KH
greg at kroah.com
Mon Mar 7 22:01:21 UTC 2011
On Mon, Mar 07, 2011 at 08:25:07PM +0100, Belisko Marek wrote:
> On Mon, Mar 7, 2011 at 4:55 PM, Dan Carpenter <error27 at gmail.com> wrote:
> > On Mon, Mar 07, 2011 at 09:21:16AM +0100, Marek Belisko wrote:
> >> - if (urb->status)
> >> - printk("%s: TX status %d\n", ft1000dev->net->name, urb->status);
> >> + if (urb->status)
> >> + DEBUG("%s: TX status %d\n", ft1000dev->net->name, urb->status);
> >>
> >
> > Why did you change the printk() to a DEBUG()? That's a behavior change,
> > and it should have been mentioned in the commit message.
> Mea culpa. checkpatch.pl complain about no KERN_... prefix so just fix with
> replace to DEBUG. Will return back to printk.
> @Greg: should resend whole serie or just this patch?
Which ever you feel ok with.
thanks,
greg k-h
More information about the devel
mailing list