[PATCH 11/21] staging: ft1000: Fix coding style in ft1000_usb_transmit_complete function.

Dan Carpenter error27 at gmail.com
Mon Mar 7 15:55:29 UTC 2011


On Mon, Mar 07, 2011 at 09:21:16AM +0100, Marek Belisko wrote:
> -    if (urb->status)
> -        printk("%s: TX status %d\n", ft1000dev->net->name, urb->status);
> +	if (urb->status)
> +		DEBUG("%s: TX status %d\n", ft1000dev->net->name, urb->status);
>  

Why did you change the printk() to a DEBUG()?  That's a behavior change,
and it should have been mentioned in the commit message.

regards,
dan carpenter

> -    netif_wake_queue(ft1000dev->net);
> +	netif_wake_queue(ft1000dev->net);
>  
>      //DEBUG("Return from ft1000_usb_transmit_complete\n");
>  }




More information about the devel mailing list