[PATCH3 5/6] staging: brcm80211: adapt driver sources to renamed source module

Arend van Spriel arend at broadcom.com
Tue Mar 1 13:44:37 UTC 2011


On Tue, 01 Mar 2011 14:26:18 +0100, Dan Carpenter <error27 at gmail.com>  
wrote:

> On Tue, Mar 01, 2011 at 10:56:58AM +0100, Arend van Spriel wrote:
>> wlc_mac80211 has been renamed to wlc_main. This commit makes the
>> required changes to the other driver files to make it compile again.
>>
>
> It would have been better to combine this one with 4/6 so that the
> code compiles after every commit.  Otherwise it breaks git bisect.
>

I thought I followed your guideline in splitting them.
Quoting:""
I know that we say you should run checkpatch on all patches, but moving
code around is the exception.  If it had just moved the code around
without the changes, then we have automated ways of reviewing that.
""

>
> regards,
> dan carpenter
>
>

Sorry for interpreting it wrong.

Gr. AvS
-- 
"The most merciful thing in the world, I think, is the inability of the  
human
mind to correlate all its contents." - "The Call of Cthulhu"




More information about the devel mailing list