[PATCH] drivers/staging/zcache: support multiple clients, prep for RAMster and KVM

Dan Magenheimer dan.magenheimer at oracle.com
Tue Jun 28 21:47:03 UTC 2011


> From: Konrad Rzeszutek Wilk

Hi Konrad --

Thanks for the review!

> Subject: Re: [PATCH] drivers/staging/zcache: support multiple clients, prep for RAMster and KVM
> 

> > +int tmem_get(struct tmem_pool *pool, struct tmem_oid *oidp, uint32_t index,
> > +		char *data, size_t *size, bool raw, int get_and_free)
> 
> And also here.. make get_and_free be bool?

This is actually a tri-state so can't be a bool.  The
other variables, as you pointed out, should be bool.
I will fix them and clarify the other two items and
post another version (and I'll remember to cc lkml
this time too ;-)

Thanks again,
Dan



More information about the devel mailing list