[PATCH] Staging: usbip: Use local pointer to reference urb in stub_recv_cmd_submit
Dan Carpenter
error27 at gmail.com
Fri Jun 17 09:34:00 UTC 2011
On Fri, Jun 17, 2011 at 11:27:57AM +0200, Tobias Klauser wrote:
> On 2011-06-17 at 11:00:29 +0200, Joey Lee <jlee at novell.com> wrote:
> > ??? ??????2011-06-16 ??? 13:38 +0200???Tobias Klauser ?????????
> > > Use a local pointer to reference the urb instead of dereferencing the
> > > priv->urb member all over the function.
> > >
> >
> > What's the benefit for use local pointer to instead of priv->urb? Does
> > it for coding style?
>
> Dereferencing a pointer can be an expensive operation, depending on the
> (cache) architecture.
I'd have to see some benchmarks before I believe that matters here. :P
regards,
dan carpenter
More information about the devel
mailing list