[PATCH 12/21] staging: brcm80211: use __BIG_ENDIAN macro in dma.c

[Arend van Spriel]

On 06/10/2011 01:53 AM, Jonas Gorski wrote:
> On 9 June 2011 16:44, Roland Vossen<rvossen at broadcom.com>  wrote:
>> From: Arend van Spriel<arend at broadcom.com>
>>
>> The source file dma.c used a macro definition that indicated a big endian
>> platform. The linux tree has its own macro determined by architecture and/or
>> kernel configuration. This byteorder macro is __BIG_ENDIAN. This is now used
>> in dma.c.
> While this replacement is technically correct, the check itself is
> wrong and should be fixed instead. Currently it assumes that __mips__
> means Broadcom MIPS; but if it isn't, then there's likely no
> SI_SDRAM_SWAPPED and any access there will in best case do nothing
> (but more like hang the system).
>
> Use either CONFIG_BCM47XX or CONFIG_BCM63XX to check for the BMIPS
> platforms this is probably intended for (I'm not 100% sure if BCM63XX
> has the swapped memory space - better check with your xDSL people ;-).

Hi Jonas,

You are right as with previous mips related patches. Consider this a 
first step which does not change functionality but aims to use the 
proper linux provided macros instead of our own incarnations. You can be 
assured that your feedback is on our work list.

Gr. AvS

-- 
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --