[PATCH 1/2 v3] Staging: comedi: fix printk() issue in adv_pci1710.c

Dan Carpenter error27 at gmail.com
Tue Jul 19 06:12:26 UTC 2011


On Tue, Jul 19, 2011 at 04:07:27PM +1000, Ryan Mallon wrote:
> This still isn't correct. The initial printk (KERN_INFO above) has
> no trailing newline. Here you are almost doing it correctly, except
> that you are adding an extra newline. This error message will look
> like this:
> 
> comedi0: adv_pci1710:
> comedi0: adv_pci1710: Allocation failed
> 

Actually kmalloc() prints an message with a stack trace on failure as
well so that would go in the middle, just before the first newline.

regards,
dan carpenter



More information about the devel mailing list