[PATCH 12/19] staging: brcm80211: remove code for unsupported chip

[Franky Lin]

On 7/18/2011 2:34:27 PM, Pavel Roskin <proski at gnu.org> wrote:
> On 07/18/2011 05:18 PM, Franky Lin wrote:
>
>> No, i didn't. Thank you for pointing out this. I missed it when I
>> rebased my local branch. It didn't break any thing because
>> brcmf_mmc_suspend is a global variable. Is it ok to keep the patch like
>> this? I will prepare another patch to put it back and put the variable
>> in a structure instead of using a global.
>
> Broken commits are bad for bisecting.  "git bisect" is used to search
> for a revision that introduces a bug.  "git bisect" selects a commit
> between the known working and the known broken revision.  If the commit
> selected by "git commit" suffers from additional breakage, this could
> lead to wasted time and possibly to a failure to find the commit
> responsible for the original problem.
>
> Please don't submit known broken commits.  You can always send another
> version of the series.  If you are using stgit, see "stg mail --help".
>

Thanks Pavel. We will send out a v2 to fix this.