[PATCH 12/19] staging: brcm80211: remove code for unsupported chip
Franky Lin
frankyl at broadcom.com
Mon Jul 18 21:18:11 UTC 2011
On 7/18/2011 12:42:15 PM, Dan Carpenter <error27 at gmail.com> wrote:
> On Mon, Jul 18, 2011 at 04:29:58PM +0200, Arend van Spriel wrote:
>> @@ -1058,12 +1028,6 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func,
>> sdio_func_0.num = 0;
>> sdio_func_0.card = func->card;
>> gInstance->func[0] =&sdio_func_0;
>> - if (func->device == 0x4) { /* 4318 */
>> - gInstance->func[2] = NULL;
>> - sd_trace(("NIC found, calling brcmf_sdio_probe...\n"));
>> - ret = brcmf_sdio_probe(&sdmmc_dev);
>> - }
>> - atomic_set(&brcmf_mmc_suspend, false);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Did you intend to delete that?
>
>> }
>>
Hi Dan
No, i didn't. Thank you for pointing out this. I missed it when I
rebased my local branch. It didn't break any thing because
brcmf_mmc_suspend is a global variable. Is it ok to keep the patch like
this? I will prepare another patch to put it back and put the variable
in a structure instead of using a global.
Thanks,
Franky
More information about the devel
mailing list