[PATCH 00/24] ath6kl cleaned up driver

Johannes Berg johannes at sipsolutions.net
Wed Jul 13 09:41:08 UTC 2011


On Wed, 2011-07-13 at 12:34 +0300, Dan Carpenter wrote:
> On Wed, Jul 13, 2011 at 11:28:44AM +0200, Johannes Berg wrote:
> > On Wed, 2011-07-13 at 12:22 +0300, Dan Carpenter wrote:
> > 
> > > warn: returning -1 instead of -ENOMEM is sloppy
> > 
> > out of curiosity -- why does it say "instead of -ENOMEM"? -1 really gets
> > interpreted as "-EPERM" (since EPERM == 1)
> 
> It's for an allocation failure.  The code returns -1 (-EPERM) but it
> should be returning -ENOMEM.

Ah, so it looks at the context of it, cool.

johannes




More information about the devel mailing list