[PATCH 01/24] ath6kl: add bmi.c

Joe Perches joe at perches.com
Wed Jul 13 04:28:53 UTC 2011


On Wed, 2011-07-13 at 04:33 +0300, Kalle Valo wrote: 
> diff --git a/drivers/net/wireless/ath/ath6kl/bmi.c b/drivers/net/wireless/ath/ath6kl/bmi.c
[] 
> +			ath6kl_err("Unable to decrement the command "
> +				   "credit count register: %d\n", ret);

I think all of these ath6kl_<level> uses in all the patches
should coalesce formats that are split across multiple lines.
This helps grepping the sources for a specific dmesg.

			ath6kl_err("Unable to decrement the command credit count register: %d\n",
				   ret);
[]
> +			ath6kl_err("unable to read target info "
> +				   "byte count: %d\n", ret);

			ath6kl_err("unable to read target info byte count: %d\n",
				   ret);
[]
> +			ath6kl_err("Unable to read target info "
> +				   "(%d bytes): %d\n",
> +				   targ_info->byte_count, ret);

			ath6kl_err("Unable to read target info %d bytes): %d\n",
				   targ_info->byte_count, ret);

etc...






More information about the devel mailing list