[RFC] Move brcm80211 to mainline

Pavel Roskin proski at gnu.org
Thu Jul 7 00:58:11 UTC 2011


On 07/06/2011 08:40 PM, Rafał Miłecki wrote:
> Short question, without commenting on brcm80211 code yet:
>
> Why should we want 2 mainline drivers for the same hardware?

Also, checkpatch.pl finds a lot of bad stuff:

total: 1 errors, 1505 warnings, 105454 lines checked

$ scripts/checkpatch.pl 0001-wireless-testing-add-brcm80211.patch >Log
$ egrep '^(WARNING|ERROR)' Log |sort |uniq -c
       1 ERROR: do not use assignment in if condition
      76 WARNING: braces {} are not necessary for any arm of this statement
     205 WARNING: braces {} are not necessary for single statement blocks
       4 WARNING: consider using a completion
      11 WARNING: consider using kstrto* in preference to simple_strtoul
      20 WARNING: do not add new typedefs
       5 WARNING: externs should be avoided in .c files
    1164 WARNING: line over 80 characters
      20 WARNING: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt

That's the "error".  It should be easy to fix.

ERROR: do not use assignment in if condition
#35077: FILE: drivers/net/wireless/brcm80211/brcmsmac/main.c:261:
+               if ((cfg = (wlc)->bsscfg[idx]))

20 typedefs seems excessive to me.

-- 
Regards,
Pavel Roskin



More information about the devel mailing list