[PATCH 07/31] staging: brcm80211: removed asserts from dhd_cdc.c and dhd_common.c

Roland Vossen rvossen at broadcom.com
Wed Jul 6 14:27:22 UTC 2011


Hi Dan,

>> @@ -317,14 +312,16 @@ brcmf_c_iovar_op(struct brcmf_pub *drvr, const char *name,
>>
>>   	BRCMF_TRACE(("%s: Enter\n", __func__));
>>
>> -	ASSERT(name);
>> -	ASSERT(len>= 0);
>> +	if (name == NULL || len<= 0)
>> +		return -EINVAL;
>>
>
> In the original code len == 0 was OK but now we return -EINVAL.

Agreed, this is non desirable behavior. We did not see a regression in 
our fullmac driver testing (which, I admit, is fairly limited at this 
stage). I will create an additional patch to fix this.

Thanks, Roland.




More information about the devel mailing list