[PATCH 3/3] staging: brcm80211: align common driver code

Greg KH gregkh at suse.de
Wed Jan 26 02:23:42 UTC 2011


On Tue, Jan 25, 2011 at 04:13:56PM +0100, Arend van Spriel wrote:
> Hi Greg,
> 
> On Tue, 25 Jan 2011 15:58:54 +0100, Greg KH <gregkh at suse.de> wrote:
> 
> >On Tue, Jan 25, 2011 at 02:32:05PM +0100, Arend van Spriel wrote:
> >>Remove differences in util sources for the two supported drivers
> >
> >But this patch also makes it possible for both to be build at the same
> >time, right?  Which should be called out here.
> >
> 
> PATCH 2 makes it possible to build the drivers at the same time, but
> I have to change that as it uses symbolic links iso include.
> 
> >Why not make that its own patch?
> >
> >>and remove default print statements.
> >
> >Ah, you used "and".  This means you should not be doing this all in one
> >patch.
> >
> 
> Ok. This means you want me to split and resubmit this patch?

Yes please.  Actually resend the whole series, as I had comments on most
of them, right?

thanks,

greg k-h



More information about the devel mailing list