[PATCH v3] Staging: bcm: Fix potential buffer overflow and style cleanups

Stephen Hemminger shemminger at vyatta.com
Mon Jan 24 21:20:23 UTC 2011


On Mon, 24 Jan 2011 23:55:31 +0300
Dan Carpenter <error27 at gmail.com> wrote:

> > 1. Your indentation looks different than original code.   
> 
> Yes, but it's the surrounding code which is wrong, and not even in a
> consistent way.  :/  We normally just ignore the surrounding code when
> it's that hopeless.
> 
> It doesn't matter either way.  The white space for the entire file will
> need to be redone in a later patch.

I prefer that you do this as two separate patches, it doesn't matter
which order. clean white space then do your fix or vice versa.



More information about the devel mailing list