[PATCH] staging: brcm80211: implementation of RFKILL functionality

[Arend Van Spriel]

Hi Greg,

It would seem to, but I am following guideline from Documentation/rfkill.txt, section 3. Kernel API:
""
To create an rfkill driver, driver's Kconfig needs to have

        depends on RFKILL || !RFKILL

to ensure the driver cannot be built-in when rfkill is modular. The !RFKILL
case allows the driver to be built when rfkill is not configured, which which
case all rfkill API can still be used but will be provided by static inlines
which compile to almost nothing.
""

I am not sure if this is really needed as cfg80211 does most of rfkill work for us.

Gr. AvS

________________________________________
From: Greg KH [gregkh at suse.de]
Sent: Wednesday, January 19, 2011 5:12 PM
To: Arend Van Spriel
Cc: devel at linuxdriverproject.org
Subject: Re: [PATCH] staging: brcm80211: implementation of RFKILL functionality

On Wed, Jan 19, 2011 at 02:27:28PM +0100, Arend van Spriel wrote:
> Only hardware switch state needs to be handled by driver. RFKILL is
> informed when hardware switch is activated. MAC80211 rfkill_poll
> callback is used to check hardware switch deactivation.
>
> Reviewed-by: Brett Rudley <brudley at broadcom.com>
> Reviewed-by: Henry Ptasinski <henryp at broadcom.com>
> Signed-off-by: Arend van Spriel <arend at broadcom.com>
> ---
>  drivers/staging/brcm80211/Kconfig                 |    1 +
>  drivers/staging/brcm80211/brcmsmac/wl_export.h    |    1 +
>  drivers/staging/brcm80211/brcmsmac/wl_mac80211.c  |   37 ++++++++++++++++++++-
>  drivers/staging/brcm80211/brcmsmac/wlc_bmac.c     |    8 +---
>  drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c |   12 ++++--
>  drivers/staging/brcm80211/brcmsmac/wlc_pub.h      |    1 +
>  6 files changed, 49 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/brcm80211/Kconfig b/drivers/staging/brcm80211/Kconfig
> index 190e7e4..53e0940 100644
> --- a/drivers/staging/brcm80211/Kconfig
> +++ b/drivers/staging/brcm80211/Kconfig
> @@ -5,6 +5,7 @@ menuconfig BRCM80211
>  config BRCMSMAC
>       bool "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver"
>       depends on PCI
> +     depends on RFKILL || !RFKILL

Isn't that redundant?

thanks,

greg k-h